-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete hardcoded focus style from Social Links #30721
Conversation
Size Change: -204 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this change works as described and looks fine in various testing. 👍
One thing I did notice (and it is the same before/after this change, so can be addressed in a different ticket if need be) but the focus on the link selected is not maintained when the URL text field is open.
There is enough context with placement and icon in the block toolbar it is clear, but since I was paying attention to focus style and states, I noticed it while reviewing:
Example:
Yes, technically that works as intended, insofar as when the URL dialog is open, focus should be there, and not on the block itself. However the experience isn't great, I agree, but I would say #29505 is the followup we need to address. What that ticket suggest is that we essentially re-create the placeholder state for the item so it works like navigation menus. |
Description
Fixes #30682.
Before the WordPress 5.5 block editor visual refresh, social links required an extra focus style. This is now obsolete, so this PR simply removes it.
Before:
After:
Checklist:
*.native.js
files for terms that need renaming or removal).